Skip to content

Integrate test Project.toml into main Project.toml#30

Merged
pjaap merged 2 commits intomasterfrom
update-test
Mar 31, 2025
Merged

Integrate test Project.toml into main Project.toml#30
pjaap merged 2 commits intomasterfrom
update-test

Conversation

@pjaap
Copy link
Copy Markdown
Member

@pjaap pjaap commented Feb 3, 2025

Let's see if it runs through

@pjaap pjaap force-pushed the update-test branch 2 times, most recently from b5bb1b7 to a35c6be Compare February 5, 2025 09:13
@pjaap
Copy link
Copy Markdown
Member Author

pjaap commented Feb 5, 2025

@chmerdon Seems fine now. I think the module is more maintainable if we have only a single Project.toml.
Adding new test dependencies can now easily be done in the [extras] section plus in the [targets] list.

@j-fu
Copy link
Copy Markdown
Member

j-fu commented Feb 6, 2025

... It is a matter of taste IMHO. I didn't find a reference stating what is preferred by the julia developers.

I personally kind of prefer to have test/Project.toml . Anyway we also have docs/Project.toml.

@pjaap
Copy link
Copy Markdown
Member Author

pjaap commented Feb 6, 2025

When I was new to Julia I was always confused by the splitting into test/main Project.toml. I think @chmerdon has to decide here :)

docs is different. For me, docs is an independent project on top of the actual module.

@chmerdon
Copy link
Copy Markdown
Member

chmerdon commented Feb 6, 2025

is docs really that independent? it runs the same examples, uses all the docstrings... I also find it weird to have then still the docs/Project.toml separately. Can one handle the docs similarly with another target docs?

@pjaap
Copy link
Copy Markdown
Member Author

pjaap commented Feb 6, 2025

Technically, docs is a project/environment on its own. You explicitly activate docs in order to create the docs.
Testing, on the other hand, is done out of the main project.

As far as I know, the only valid [targets] are test and build (see Julia Doc).

And I think 2 Project.toml files are still better than 3 separate files :)

@pjaap
Copy link
Copy Markdown
Member Author

pjaap commented Mar 31, 2025

Rebased to current master. Will merge if CI passes.

@j-fu
Copy link
Copy Markdown
Member

j-fu commented Mar 31, 2025

@pjaap
Copy link
Copy Markdown
Member Author

pjaap commented Mar 31, 2025

From the discussion I take home that the current creation of the test environment is a mess if a separate test project is provided. I would really prefer to test in the environment of the project itself, sice we basically do full example testing here.
This is exactly what a downstream package would do. Create a script, add additional deps and run. This is what the [extras] do for us, right?

We seem to have some weird compat problems along the WIAS-PDELib. Let us keep things as simple as possible to track down these problems.
If a future development clears the relation to the main project and the test project, simply revert this change. It just takes a few minutes to set up a separate test environment again.

PS: Right now the CI fails since before the test environment was different than it is now. This pretty much underlines my argument.

@j-fu
Copy link
Copy Markdown
Member

j-fu commented Mar 31, 2025

... the currently failing test doesn't seem to fail due to CI configuration, but seems to assume that mesh generation always results in the same grid size, however due to floating point arithmetic this is true only approximately.

@j-fu
Copy link
Copy Markdown
Member

j-fu commented Mar 31, 2025

In VoronoiFVM you can look up how to test on Apple Silicon, I would add this here.

@pjaap
Copy link
Copy Markdown
Member Author

pjaap commented Mar 31, 2025

Yes, you are right. The CI fail occurred before on the master branch after merging the latest PRs. You think this is caused by floating point arithmetic problems? Why did the test work before?

This fails due to some rounding errors. See #44
@pjaap
Copy link
Copy Markdown
Member Author

pjaap commented Mar 31, 2025

As suggested by @chmerdon I deactivated Example211 for now. As a reminder I opened #44.

@pjaap pjaap merged commit a424b9d into master Mar 31, 2025
8 checks passed
@pjaap pjaap deleted the update-test branch January 28, 2026 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants